[alertmanager] Add additional configuration options. #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
sam-mcbr
force-pushed
the
alertmanager-ha
branch
from
8ff3606
to
886f6cf
Compare
|
@monotek @naseemkullah Don't mean to be a bother, but I would love to try to get a fix in so I can run in HA quickly so I can deploy this. I'm more than happy to make any necessary edits/improvements. Just wanted to give a heads up that this is a priority for me 😄 |
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
|
And apologies, I did just notice a few other config options that would be useful so I added those. But this is ready to go now, thanks! |
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
monotek
requested changes
Jul 25, 2023
Signed-off-by: Sam Mcbroom <[email protected]>
…unity-helm-charts into alertmanager-ha
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
Signed-off-by: Sam Mcbroom <[email protected]>
sam-mcbr
commented
Aug 1, 2023
monotek
approved these changes
Aug 7, 2023
|
Thank you all so much! |
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Aug 25, 2023
…unity#3620) * [alertmanager] Add additional configuration options. Signed-off-by: Sam Mcbroom <[email protected]> * Use port names. Signed-off-by: Sam Mcbroom <[email protected]> * Extra volume mounts for config reloader. Signed-off-by: Sam Mcbroom <[email protected]> * Add extraEnv value for config reloader. Signed-off-by: Sam Mcbroom <[email protected]> * Allow restricting config-reloader to only watch specific file. Signed-off-by: Sam Mcbroom <[email protected]> * Allow configuring reload endpoint for config reloader. Signed-off-by: Sam Mcbroom <[email protected]> * Fix comments in values.yaml. Signed-off-by: Sam Mcbroom <[email protected]> * Allow exposing extra ports on the services. Signed-off-by: Sam Mcbroom <[email protected]> * Default value for service.extraPorts. Signed-off-by: Sam Mcbroom <[email protected]> * Remove unused service port protocol. Signed-off-by: Sam Mcbroom <[email protected]> * Fix helm. Signed-off-by: Sam Mcbroom <[email protected]> * Enabled UDP port for cluster peer communication. Signed-off-by: Sam Mcbroom <[email protected]> * Bump version. Signed-off-by: Sam Mcbroom <[email protected]> --------- Signed-off-by: Sam Mcbroom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR fixes a bug when trying to deploy alertmanager HA. The cluster port is set to
9094but the StatefulSet only ever exposes9093. This PR additionally adds some extra configuration options at allow more flexible uses of the config-reloader.Which issue this PR fixes
Special notes for your reviewer
Would love to get this merged quickly as the port issue is a blocker for me deploy the chart. Happy to discuss and iterate on this if needed! Thanks!
Checklist
[prometheus-couchdb-exporter])